[PATCH] Teach scalarrepl about address spaces

[Quentin Colombet]

  Hi Matt,

  LGTM with one minor comment:
  One of your test is missing CHECK lines or should be removed.

  Thanks,
  -Quentin


================
Comment at: test/Transforms/ScalarRepl/union-pointer.ll:2
@@ -1,5 +1,3 @@
 ; PR892
-; RUN: opt < %s -scalarrepl -S | \
-; RUN:   not grep alloca
-; RUN: opt < %s -scalarrepl -S | grep "ret i8"
+; RUN: opt < %s -scalarrepl -S | FileCheck %s
 
----------------
Thanks for this clean up.

================
Comment at: test/Transforms/ScalarRepl/union-pointer.ll:33
@@ +32,3 @@
+
+define i8 addrspace(1)* @test_as1_array(i16 addrspace(1)* %x) {
+  %as_ptr_array = alloca [4 x i16 addrspace(1)*]
----------------
Is this missing some CHECK lines or should it be removed?


http://llvm-reviews.chandlerc.com/D1779