[PATCH] [AArch64] Make FP instructions optional

Amara Emerson amara.emerson at arm.com
Wed Oct 30 11:06:12 PDT 2013


  Thanks Tim. New patch arriving shortly.


================
Comment at: test/MC/AArch64/basic-a64-instructions.s:1
@@ -1,2 +1,2 @@
-// RUN: llvm-mc -triple aarch64-none-linux-gnu -show-encoding < %s | FileCheck %s
+// RUN: llvm-mc -triple aarch64-none-linux-gnu -show-encoding -mattr=+fp-armv8 < %s | FileCheck %s
   .globl _func
----------------
Tim Northover wrote:
> Is this -mattr needed? I really hope not...
AFAIK this is consistent with llvm-mc, e.g. in the ARM backend you also have to specify each feature.

================
Comment at: test/CodeGen/AArch64/variadic.ll:139-141
@@ +138,5 @@
+  call void @llvm.va_start(i8* %addr)
+; FP-NOT: sub sp, sp
+; FP: mov [[STACK:x[0-9]+]], sp
+; FP: str [[STACK]], [{{x[0-9]+}}, #:lo12:var]
+
----------------
Tim Northover wrote:
> This is the wrong prefix now. It's not being checked.
Gah, will fix.


http://llvm-reviews.chandlerc.com/D2052



More information about the llvm-commits mailing list