[PATCH] NEON instructions were erroneously decoded from certain invalid encodings

Artyom Skrobov Artyom.Skrobov at arm.com
Wed Oct 30 09:51:47 PDT 2013


Tim, unfortunately such a test is impossible: for all instructions in the
v8NEON32 range, the aliasing encodings are defined as valid instructions, so
these definitions are checked before masking the encoding and matching it
against DecoderTablev8NEON32.

It's pure luck that for sha256h one of the aliasing encodings were
undefined, which gave this error away.

OK to commit the test as it is?


-----Original Message-----
From: Tim Northover [mailto:t.p.northover at gmail.com] 
Sent: 30 October 2013 15:40
To: Artyom Skrobov
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [PATCH] NEON instructions were erroneously decoded from certain
invalid encodings

Hi Artyom,

> OK to commit this fix?

Could you add a test using an instruction that would be in the
v8NEON32 space too? I'm happy for you to commit with that change, and
I'll take a last look at it in post-commit.

Cheers.

Tim.








More information about the llvm-commits mailing list