[PATCH] Make v7(e)m default to thumb

[Bernie Ogden]

Thanks for the pointer - I'm not looking to get involved in a refactoring
right now, but I'd love it if someone did.

 

Posted two patches on phabricator (the second is basically the same one
again). I hope that fixes things well enough to be going on with.

 

http://llvm-reviews.chandlerc.com/D2061

http://llvm-reviews.chandlerc.com/D2062

 

 

From: Renato Golin [mailto:renato.golin at linaro.org] 
Sent: 19 October 2013 11:49
To: Bernard Ogden
Cc: James Molloy; LLVM Commits
Subject: Re: [PATCH] Make v7(e)m default to thumb

 

Hi Bernie,

 

FYI, I just remembered that there was a bug related to the one you're
working on:

 

http://llvm.org/bugs/show_bug.cgi?id=17120

 

It's just a refactoring and is not necessarily associated with, but is a
good path towards a more sane driver, and could make your own change a lot
easier. I won't be looking at it for the next months, feel free to implement
it if you want/need.

 

cheers,

--renato

 

On 16 October 2013 09:03, Bernie Ogden <bogden at arm.com> wrote:

Hi James,

 

There's already a test there, but it relies on the target being darwin. We
ought to be testing in general. I'll fix that.

 

Thanks,

 

Bernie

 

From: mankeyrabbit at gmail.com [mailto:mankeyrabbit at gmail.com] On Behalf Of
James Molloy
Sent: 15 October 2013 16:45


To: Bernard Ogden
Cc: LLVM Commits

Subject: Re: [PATCH] Make v7(e)m default to thumb

 

Hi Bernie,

 

Generally LGTM - I'd prefer a testcase testing v6m too though (Cortex-M0 or
M0+).

 

Cheers,

 

James

 

On 15 October 2013 15:53, Bernie Ogden <bogden at arm.com> wrote:

Attached simple patch makes thumb the default for armv7m and armv7em. Given
that these targets don't support arm, this has to be a Good Thing.

Fixes http://llvm.org/bugs/show_bug.cgi?id=17559.

Note that this only fixes the clang side. M'colleague pointed out that other
LLVM tools (e.g. llc) are broken in this respect. I took a look at what
would be required to fix this and decided not to go there.

Please review.

Regards,

Bernie
_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

 


_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131030/efe7627d/attachment.html>