[PATCH] Update to Cmake for VS 2013

Aaron Ballman aaron at aaronballman.com
Tue Oct 29 16:22:06 PDT 2013


Here's a patch with an attempt at llvm::huge_valf (I also included
vald and vall for consistency).  It compiles cleanly with VS 2013,
though it's impossible to tell how it affects tests since there is
currently a miscompile that causes most of them to crash.

~Aaron

On Tue, Oct 29, 2013 at 6:55 PM, Reid Kleckner <rnk at google.com> wrote:
> On Tue, Oct 29, 2013 at 3:48 PM, Aaron Ballman <aaron at aaronballman.com>
> wrote:
>>
>> There were about 15 warnings in several places from it.
>>
>> LiveIntervalAnalysis.cpp
>> RegAllocGreedy.cpp in three places
>> Spiller.cpp
>> LiveInterval.h in two places
>>
>> If it was just in a single header file and getting tripped over on
>> include, I would be okay with it, but it's a bit more widely dispersed
>> than that.
>>
>> Alternatively, we could make an llvm::huge_valf that does suppress the
>> warning and gets used in place of HUGE_VALF, if that's preferable?
>
>
> llvm::huge_valf does sound preferable, as annoying as it is not to be able
> to use standard stuff from math.h.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: huge_valf.patch
Type: application/octet-stream
Size: 3954 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131029/566c8919/attachment.obj>


More information about the llvm-commits mailing list