[PATCH] Update to Cmake for VS 2013

Aaron Ballman aaron at aaronballman.com
Tue Oct 29 15:48:52 PDT 2013


There were about 15 warnings in several places from it.

LiveIntervalAnalysis.cpp
RegAllocGreedy.cpp in three places
Spiller.cpp
LiveInterval.h in two places

If it was just in a single header file and getting tripped over on
include, I would be okay with it, but it's a bit more widely dispersed
than that.

Alternatively, we could make an llvm::huge_valf that does suppress the
warning and gets used in place of HUGE_VALF, if that's preferable?

~Aaron

On Tue, Oct 29, 2013 at 6:44 PM, Reid Kleckner <rnk at google.com> wrote:
> We consider the equivalent warning in clang to be very high value.  I only
> see one use of HUGE_VAL (through HUGE_VALF) in LiveInterval.h.  What do you
> think about wrapping it in pragmas to suppress the warning locally?
>
>
> On Tue, Oct 29, 2013 at 2:07 PM, Aaron Ballman <aaron at aaronballman.com>
> wrote:
>>
>> Visual Studio 2013 will generate a warning on any usage of HUGE_VAL
>> (or similar) due to the way it is implemented.  This patch suppresses
>> that warning just for VS 2013 so that we can compile cleanly again.
>>
>> ~Aaron
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>



More information about the llvm-commits mailing list