[PATCH] Add {start,end}with_lower methods to StringRef.

Rui Ueyama ruiu at google.com
Tue Oct 29 13:45:51 PDT 2013



================
Comment at: lib/Support/StringRef.cpp:56
@@ -51,2 +55,3 @@
+    return ascii_strncasecmp(Data, RHS.Data, Length);
   return Length < RHS.Length ? -1 : 1;
 }
----------------
Reid Kleckner wrote:
> This doesn't look like it matches the behavior of strcasecmp.  The most intuitive way to test this to me is to write a test that sorts an array of strings.
Huh, this is a silly error, and it's surprising no LLVM tests failed. Added a few more tests to catch this bug.


http://llvm-reviews.chandlerc.com/D2041



More information about the llvm-commits mailing list