[llvm] r193604 - Quick-fix DebugInfo build on Windows

[Timur Iskhodzhanov]

Feel free to review the "fix FIXME" patch here
http://llvm-reviews.chandlerc.com/D2050

2013/10/29 Timur Iskhodzhanov <timurrrr at google.com>:
> Author: timurrrr
> Date: Tue Oct 29 07:13:22 2013
> New Revision: 193604
>
> URL: http://llvm.org/viewvc/llvm-project?rev=193604&view=rev
> Log:
> Quick-fix DebugInfo build on Windows
>
> MSVC can't comprehend
>   template<typename T, size_t N>
>   ArrayRef<T> makeArrayRef(const T (&Arr)[N]) {
>     return ArrayRef<T>(Arr);
>   }
> if Arr is
>   static const uint8_t sizes[];
> declared in a templated and defined a few lines later.
>
> I'll send a proper fix (i.e. get rid of unnecessary templates) for review soon.
>
>
> Modified:
>     llvm/trunk/lib/DebugInfo/DWARFFormValue.cpp
>
> Modified: llvm/trunk/lib/DebugInfo/DWARFFormValue.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARFFormValue.cpp?rev=193604&r1=193603&r2=193604&view=diff
> ==============================================================================
> --- llvm/trunk/lib/DebugInfo/DWARFFormValue.cpp (original)
> +++ llvm/trunk/lib/DebugInfo/DWARFFormValue.cpp Tue Oct 29 07:13:22 2013
> @@ -22,7 +22,9 @@ using namespace dwarf;
>
>  namespace {
>  template <uint8_t AddrSize, uint8_t RefAddrSize> struct FixedFormSizes {
> -  static const uint8_t sizes[];
> +  // FIXME: do we need a template here?  Will a stack-allocated struct with
> +  // an initializer in getFixedFormSizes() work just fine?
> +  static const uint8_t sizes[27];
>  };
>  }
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits