================ Comment at: lib/MC/ELFObjectWriter.cpp:891 @@ +890,3 @@ + ++it) { + StringRef Name = *it; + uint64_t &Entry = StringIndexMap[Name]; ---------------- I'm not using the iterator directly here to keep the symmetry with the following loops. http://llvm-reviews.chandlerc.com/D2043