[llvm] r193544 - Standardizing lli's extra module command line option

Alp Toker alp at nuanti.com
Mon Oct 28 15:57:19 PDT 2013


On 28/10/2013 22:22, Alp Toker wrote:
> On 28/10/2013 21:58, Andrew Kaylor wrote:
>> Modified: llvm/trunk/tools/lli/lli.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/lli/lli.cpp?rev=193544&r1=193543&r2=193544&view=diff
>> ==============================================================================
>> --- llvm/trunk/tools/lli/lli.cpp (original)
>> +++ llvm/trunk/tools/lli/lli.cpp Mon Oct 28 16:58:15 2013
>> @@ -132,8 +132,7 @@ namespace {
>>              cl::init("main"));
>>  
>>    cl::list<std::string>
>> -  ExtraModules("extra-modules",
>> -         cl::CommaSeparated,
>> +  ExtraModules("extra-module",
>>           cl::desc("Extra modules to be loaded"),
>>           cl::value_desc("<input bitcode 2>,<input bitcode 3>,..."));
> I think this needs to be cl::ZeroOrMore. Also don't forget to update the
> cl::value_desc.

Actually cl::ZeroOrMore is the default so no problem here.

I just fixed the cl::value_desc in r193552 BTW.

Alp.

-- 
http://www.nuanti.com
the browser experts




More information about the llvm-commits mailing list