[PATCH] DebugInfo: Introduce the notion of "form classes"

[Eric Christopher]

  Seems pretty reasonable other than the need for a few more comments.


================
Comment at: include/llvm/DebugInfo/DWARFFormValue.h:65
@@ -47,6 +64,3 @@
 
-  uint64_t getReference(const DWARFUnit *U) const;
-  uint64_t getUnsigned() const { return Value.uval; }
-  int64_t getSigned() const { return Value.sval; }
-  const char *getAsCString(const DWARFUnit *U) const;
-  uint64_t getAsAddress(const DWARFUnit *U) const;
+  Optional<uint64_t> getAsReference(const DWARFUnit *U) const;
+  Optional<uint64_t> getAsUnsignedConstant() const;
----------------
Comments about what's optional here please.


http://llvm-reviews.chandlerc.com/D1961

BRANCH
  svn

ARCANIST PROJECT
  llvm