[PATCH] Additional features for the C API

Peter Zotov whitequark at whitequark.org
Mon Oct 28 15:07:24 PDT 2013



================
Comment at: include/llvm-c/Core.h:1201
@@ +1200,3 @@
+ */
+void LLVMPrintValue(LLVMValueRef Val, int FD);
+
----------------
Perhaps PrintValueToFD to be consistent with ToFile, ToString, ...?

================
Comment at: include/llvm-c/TargetMachine.h:141
@@ +140,3 @@
+/** Create a new triple object from a string. */
+LLVMTripleRef LLVMCreatetriple(char* String);
+
----------------
CreateTriple (capitalization). Also, perhaps const char* ?

================
Comment at: include/llvm-c/TargetMachine.h:136
@@ +135,3 @@
+/** Set the target machine's ASM verbosity. */
+void LLVMSetTargetMachineASMVerbosity(LLVMTargetMachineRef Machine,
+                                      int Boolean);
----------------
Perhaps AsmVerbosity (consistency with LLVMTargetHasAsmBackend)?

================
Comment at: include/llvm-c/TargetMachine.h:67
@@ +66,3 @@
+ * Returns a string of features built from an arg array.  The caller is
+ * responsible for freeing the returned string.
+ */
----------------
I think the usual wording is "the caller should call LLVMDisposeMessage on the result"


http://llvm-reviews.chandlerc.com/D1960



More information about the llvm-commits mailing list