lli and the .ir file extension

[Kaylor, Andrew]

Hi Alp,

The '.ir' extension, as I'm using it, is exactly equivalent to the '.ll' extension.  The reason I used it was to have a way to specify additional files that would be used to provide secondary module definitions in lit tests without the testing framework trying to use them as test definitions themselves.  If there is a better way to do this, I'd be happy to change it.

As for the related '-extra-modules' flag added to lli, I'll update it in accordance with your suggestion.

Thanks,
Andy


From: Alp Toker [mailto:alp at nuanti.com]
Sent: Monday, October 28, 2013 2:34 PM
To: Kaylor, Andrew
Cc: cfe commits
Subject: lli and the .ir file extension

Hello Andrew,

In r191938, r192021 and r192504 you introduced a new file extension ".ir" to the LLVM project.

Could you document this extension and how it differs from the existing ".ll" format, or otherwise update the tools to use one of the two existing well-known extensions ".ll" or ".bc"?

Additionally, the "-extra-modules" flag added to lli in r191938 takes a comma-separated list of filenames(!)

It'd be better to handle this the usual way with something like "-module fileA.ext -module fileB.ext" following the convention of other commands. This should just be a matter of removing cl::CommaSeparated from the cl::opt in lli.cpp.

Background: I've been adding a validator to lit and these two have needed hacky special-casing so far.

Related files:

  test/ExecutionEngine/MCJIT/cross-module-b.ir
  test/ExecutionEngine/MCJIT/multi-module-b.ir
  test/ExecutionEngine/MCJIT/multi-module-c.ir
  test/ExecutionEngine/MCJIT/multi-module-eh-b.ir
  test/ExecutionEngine/MCJIT/remote/cross-module-b.ir
  test/ExecutionEngine/MCJIT/remote/multi-module-b.ir
  test/ExecutionEngine/MCJIT/remote/multi-module-c.ir


Alp.



--

http://www.nuanti.com

the browser experts
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131028/21e1afeb/attachment.html>