[PATCH] Workaround MSVC 32-bit miscompile of getCondCodeAction

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Mon Oct 28 06:35:02 PDT 2013


  LGTM with the comment about using +31/32 and dsanders' comment about one of the comments being out of date.


================
Comment at: include/llvm/Target/TargetLowering.h:1421
@@ -1420,3 +1420,1 @@
-  /// the MVT::LAST_VALUETYPE by 32 and adding one.
-  uint64_t CondCodeActions[ISD::SETCC_INVALID][(MVT::LAST_VALUETYPE / 32) + 1];
 
----------------
LAST_VALUETYPE is not a legal value, so you can use
(MVT::LAST_VALUETYPE + 31)/32, no


http://llvm-reviews.chandlerc.com/D1568



More information about the llvm-commits mailing list