[llvm] r193463 - lit: handle late multiprocessing errors gracefully

[Alp Toker]

On 28/10/2013 10:09, Sylvestre Ledru wrote:
> Hello,
>
> On 26/10/2013 10:22, Alp Toker wrote:
>> Author: alp
>> Date: Sat Oct 26 03:22:44 2013
>> New Revision: 193463
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=193463&view=rev
>> Log:
>> lit: handle late multiprocessing errors gracefully
>>
>> This should be a better fix for lit multiprocessing failures, replacing the
>> OpenBSD and FreeBSD workarounds in r193413 and r193457.
>>
> This commit broke the code coverage of LLVM [1] (runs under Debian
> GNU/Linux unstable amd64)
> The testsuite cannot be run with Python 2.7. It fail with:
>
> -- Testing: 6715 tests, 8 threads --
> Traceback (most recent call last):
>   File "/tmp/buildd/llvm-toolchain-snapshot-3.4~svn193508/utils/lit/lit.py", line 5, in <module>
>     lit.main()
>   File "/tmp/buildd/llvm-toolchain-snapshot-3.4~svn193508/utils/lit/lit/main.py", line 327, in main
>     opts.useProcesses)
>   File "/tmp/buildd/llvm-toolchain-snapshot-3.4~svn193508/utils/lit/lit/run.py", line 217, in execute_tests
>     canceled_flag =  multiprocessing.Value('i', 0)
>   File "/usr/lib/python2.7/multiprocessing/__init__.py", line 253, in Value
>     return Value(typecode_or_type, *args, **kwds)
>   File "/usr/lib/python2.7/multiprocessing/sharedctypes.py", line 103, in Value
>     lock = RLock()
>   File "/usr/lib/python2.7/multiprocessing/__init__.py", line 183, in RLock
>     return RLock()
>   File "/usr/lib/python2.7/multiprocessing/synchronize.py", line 172, in __init__
>     SemLock.__init__(self, RECURSIVE_MUTEX, 1, 1)
>   File "/usr/lib/python2.7/multiprocessing/synchronize.py", line 75, in __init__
>     sl = self._semlock = _multiprocessing.SemLock(kind, value, maxvalue)
> OSError: [Errno 38] Function not implemented
> make[3]: *** [all] Error 1
> See [2] for the full log
>
> Could you fix that ?

Fixed in r193516..

I'm a little surprised because that commit shouldn't have enabled
anything new outside of BSD.

Are you sure the test suite wasn't already failing on your builder
before r193463?

Alp.


>
> Thanks,
> Sylvestre
>
> [1] http://buildd-clang.debian.net/coverage/
> [2]
> http://llvm-jenkins.debian.net/job/llvm-toolchain-codecoverage-binaries/architecture=amd64,distribution=unstable/384/consoleFull
>

-- 
http://www.nuanti.com
the browser experts