[PATCH] lit: Incremental test scheduling

Alp Toker alp at nuanti.com
Sun Oct 27 19:09:10 PDT 2013


On 28/10/2013 01:45, Andrew Trick wrote:
> I really want this feature. It may not be clean, but would save a lot
> of time in practice. However...
>
> On Oct 24, 2013, at 10:35 PM, Alp Toker <alp at nuanti.com
> <mailto:alp at nuanti.com>> wrote:
>
>> lit shell tests and compiled unit tests are both supported. At the
>> moment, the cache is implemented by scanning and modifying test
>> source mtimes directly. This hasn't caused trouble but the technique
>> could be refined in future to store test failures in a separate cache
>> file if needed.
>
> This doesn’t feel right. I don’t think it will personally cause me any
> grief, but seems like someone or their tools will be confused. If
> others think it’s ok, I won’t object. I just don’t want to accept the
> patch until others review this aspect.

I agree, no build / test tool should touch the source directory so this
feature isn't really ready for landing yet.

I'm willing to take a stab at storing the cache in a local file, but
wanted to gage the level of interest first.

In my experience this is the kind of feature where once you have it,
it's hard to go back :-)

Alp.


-- 
http://www.nuanti.com
the browser experts




More information about the llvm-commits mailing list