[PATCH] Lower stackmap intrinsics directly to their target opcode.
Chris Lattner
clattner at apple.com
Sat Oct 26 18:15:44 PDT 2013
On Oct 21, 2013, at 8:16 PM, Andrew Trick <atrick at apple.com> wrote:
> Hi lhames, ributzka, echristo,
>
> SelectionDAGBuilder code for lowering llvm.experimental.stackmap into TargetOpcode::STACKMAP. Same for patchpoint.
>
> http://llvm-reviews.chandlerc.com/D1995
>
> Files:
> include/llvm/Target/Target.td
> include/llvm/Target/TargetLowering.h
> include/llvm/Target/TargetOpcodes.h
> lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
> lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h
> lib/CodeGen/SelectionDAG/TargetLowering.cpp
> utils/TableGen/CodeGenTarget.cpp
It looks like you have several 80 column violations, e.g.:
+ assert(CallEnd->getOpcode() == ISD::CALLSEQ_END && "Expected a callseq node.");
+ std::pair<SDValue, SDValue> Result = LowerCallOperands(CI, 4, NumArgs, Callee);
+ assert(CallEnd->getOpcode() == ISD::CALLSEQ_END && "Expected a callseq node.");
but otherwise, LGTM.
-Chris
More information about the llvm-commits
mailing list