[lld] r193451 - [ELF] Implement .{init,fini}_array ordering.

Michael Spencer bigcheesegs at gmail.com
Sat Oct 26 13:53:50 PDT 2013


On Sat, Oct 26, 2013 at 1:00 PM, Shankar Easwaran
<shankare at codeaurora.org>wrote:

> Hi Michael,
>
>
> On 10/25/2013 6:59 PM, Michael J. Spencer wrote:
>
>> Author: mspencer
>> Date: Fri Oct 25 18:59:06 2013
>> New Revision: 193451
>>
>> URL: http://llvm.org/viewvc/llvm-**project?rev=193451&view=rev<http://llvm.org/viewvc/llvm-project?rev=193451&view=rev>
>> Log:
>> [ELF] Implement .{init,fini}_array ordering.
>>
> Could this be implemented in the ELFLayout, and having a seperate
> InitArray/FiniArray section chunk ?. As we are only fixing the order within
> these sections right ?
>
> Thoughts ?


It could. But I don't see the point in adding that complexity.

- Michael Spencer


>
>
> +
> +    // Get priortiy
>
> Nit pick, Spell error.
>
> I think clang-format could detect spell errors possibly as an enhancement
> :)
>
> Thanks
>
> Shankar Easwaran
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted
> by the Linux Foundation
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131026/95298666/attachment.html>


More information about the llvm-commits mailing list