[llvm] r193459 - llvm/test/lit.cfg: Tighten conditions to enable 'native'.

Alp Toker alp at nuanti.com
Fri Oct 25 20:22:39 PDT 2013


The old check exists in clang/test/lit.cfg too, does it need the same fix?

|# Native compilation: host arch == target arch||
||if config.host_arch in config.target_triple:||
||    config.available_features.add("native")|

Alp.

On 26/10/2013 03:50, NAKAMURA Takumi wrote:
> Author: chapuni
> Date: Fri Oct 25 21:50:20 2013
> New Revision: 193459
>
> URL: http://llvm.org/viewvc/llvm-project?rev=193459&view=rev
> Log:
> llvm/test/lit.cfg: Tighten conditions to enable 'native'.
>
> I saw the case that 'native' was mis-enabled when x86_64-pc-win32 on x86_64-linux.
>
> FIXME: Consider cases that target can be executed even if host_triple were different from target_triple.
>
> Modified:
>     llvm/trunk/test/lit.cfg
>
> Modified: llvm/trunk/test/lit.cfg
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/lit.cfg?rev=193459&r1=193458&r2=193459&view=diff
> ==============================================================================
> --- llvm/trunk/test/lit.cfg (original)
> +++ llvm/trunk/test/lit.cfg Fri Oct 25 21:50:20 2013
> @@ -297,7 +297,9 @@ if config.have_zlib == "1":
>      config.available_features.add("zlib")
>  
>  # Native compilation: host arch == target arch
> -if config.host_arch in config.target_triple:
> +# FIXME: Consider cases that target can be executed
> +# even if host_triple were different from target_triple.
> +if config.host_triple == config.target_triple:
>      config.available_features.add("native")
>  
>  # llc knows whether he is compiled with -DNDEBUG.
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-- 
http://www.nuanti.com
the browser experts

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131026/ab5efd4f/attachment.html>


More information about the llvm-commits mailing list