[PATCH] [PECOFF][ELF][Darwin] Changes to fix some real issues in code

Rui Ueyama ruiu at google.com
Fri Oct 25 11:26:50 PDT 2013



================
Comment at: lib/ReaderWriter/PECOFF/IdataPass.h:281
@@ -280,3 +271,1 @@
-    for (auto hna : context.hintNameAtoms)
-      context.file.addAtom(*hna);
   }
----------------
I don't get the point of this change. The code is in use. Why are you removing this?

================
Comment at: lib/ReaderWriter/PECOFF/PECOFFLinkingContext.cpp:150
@@ -149,3 +129,1 @@
-    LLD_CASE(IMAGE_REL_I386_REL32)
-  }
   return make_error_code(YamlReaderError::illegal_value);
----------------
Ditto


http://llvm-reviews.chandlerc.com/D2022



More information about the llvm-commits mailing list