[PATCH] [bugpoint] Increase the default memory limit for subprocesses to 300MB.

[Daniel Sanders]

> -----Original Message-----
> From: Hal Finkel [mailto:hfinkel at anl.gov]
> Sent: 25 October 2013 16:32
> To: Daniel Sanders
> Cc: llvm-commits at cs.uiuc.edu; Rafael Espíndola;
> reviews+D2013+public+4f36bb97834176c2 at llvm-reviews.chandlerc.com
> Subject: Re: [PATCH] [bugpoint] Increase the default memory limit for
> subprocesses to 300MB.
> 
> ----- Original Message -----
> >
> >
> >
> > Thanks for the review. I've seen Hal's question to Chris so I'll hold
> > off on committing for now.
> >
> 
> I did not mean for that question to preempt Rafael's approval (I think that
> the messages crossed mid-stream). If Chris does not respond soon, go ahead
> and commit.
> 
>  -Hal

Ok then.
 
> > By the way, Hal's question doesn’t appear on the phabricator web
> > interface even though it's magic email address was CC'd.
> >
> >
> 
> Maybe because it was top posted?
> 
>  -Hal

That doesn't seem to be it. I top posted as well and mine appears. I'm currently wondering if it might be because you aren't on the reviewer or cc lists (except via llvm-commits). I'll experiment on a dummy revision.

> > From: Rafael Espíndola [mailto:rafael.espindola at gmail.com]
> > Sent: 24 October 2013 16:59
> > To: reviews+D2013+public+4f36bb97834176c2 at llvm-
> reviews.chandlerc.com
> > Cc: jyasskin at gmail.com; Daniel Sanders; llvm-commits at cs.uiuc.edu
> > Subject: Re: [PATCH] [bugpoint] Increase the default memory limit for
> > subprocesses to 300MB.
> >
> >
> >
> > Lgtm
> >
> > On Thursday, October 24, 2013, Daniel Sanders wrote:
> >
> > Hi jyasskin,
> >
> > Currently shared library builds (BUILD_SHARED_LIBS=ON in cmake) fail
> > three bugpoint tests (BugPoint/remove_arguments_test.ll,
> > BugPoint/crash-narrowfunctiontest.ll, and BugPoint/metadata.ll).
> >
> > If I run the bugpoint commands that llvm-lit runs with without
> > -silence-passes I see errors such as this:
> > opt: error while loading shared libraries: libLLVMSystemZInfo.so:
> > failed to
> > map segment from shared object: Cannot allocate memory
> >
> > It seems that the increased size of the binaries in a shared library
> > build is causing the subprocess to exceed the 100MB memory limit. This
> > patch therefore increases the default limit to a level at which these
> > tests pass.
> >
> > http://llvm-reviews.chandlerc.com/D2013
> >
> > Files:
> > tools/bugpoint/bugpoint.cpp
> >
> > Index: tools/bugpoint/bugpoint.cpp
> >
> ==========================================================
> =========
> > --- tools/bugpoint/bugpoint.cpp
> > +++ tools/bugpoint/bugpoint.cpp
> > @@ -49,8 +49,8 @@
> >
> > static cl::opt<int>
> > MemoryLimit("mlimit", cl::init(-1), cl::value_desc("MBytes"),
> > - cl::desc("Maximum amount of memory to use. 0 disables check."
> > - " Defaults to 100MB (800MB under valgrind)."));
> > + cl::desc("Maximum amount of memory to use. 0 disables check."
> > + " Defaults to 300MB (800MB under valgrind)."));
> >
> > static cl::opt<bool>
> > UseValgrind("enable-valgrind",
> > @@ -152,7 +152,7 @@
> > if (sys::RunningOnValgrind() || UseValgrind) MemoryLimit = 800; else
> > - MemoryLimit = 100;
> > + MemoryLimit = 300;
> > }
> >
> > BugDriver D(argv[0], FindBugs, TimeoutValue, MemoryLimit,
> 
> --
> Hal Finkel
> Assistant Computational Scientist
> Leadership Computing Facility
> Argonne National Laboratory