[PATCH] Add std::string to YAML I/O built-in types

John Thompson john.thompson.jtsoftware at gmail.com
Thu Oct 24 17:15:25 PDT 2013


It was already declared in a tooling header, but somehow I missed it, even
though I ran make on a Linux build with my changes.  It might be that that
was the only issue, but I'm too chicken today to give it another shot.
Maybe tomorrow...


On Thu, Oct 24, 2013 at 5:03 PM, Sean Silva <silvas at purdue.edu> wrote:

>
>
>
> On Thu, Oct 24, 2013 at 11:35 AM, John Thompson <
> john.thompson.jtsoftware at gmail.com> wrote:
>
>>
>>   It broke a number of builds, so I'm taking a more local approach with a
>> local mapping.
>>
>
> What exactly was the issue with introducing this functionality? I can't
> imagine that there would be a fundamental issue with doing this (e.g.,
> there might be some issues where the client code needs to be tightened up,
> but they can just be fixed up at the usage sites).
>
> I really don't think a local mapping is the right approach (unless there's
> some truly fundamental issue with having this specialization).
>
> -- Sean Silva
>
>
>>
>> http://llvm-reviews.chandlerc.com/D2006
>>
>
>


-- 
John Thompson
John.Thompson.JTSoftware at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131024/e7cc83d9/attachment.html>


More information about the llvm-commits mailing list