[llvm] r193291 - Optimizing MCJIT module state tracking

[Kaylor, Andrew]

Hi Chandler,

Thanks for handling that.  That code actually should not have been deleted in the first place.  I guess I was confusing it with something else.

-Andy


From: Chandler Carruth [mailto:chandlerc at google.com]
Sent: Thursday, October 24, 2013 2:57 AM
To: Kaylor, Andrew
Cc: Commit Messages and Patches for LLVM
Subject: Re: [llvm] r193291 - Optimizing MCJIT module state tracking


On Wed, Oct 23, 2013 at 5:19 PM, Andrew Kaylor <andrew.kaylor at intel.com<mailto:andrew.kaylor at intel.com>> wrote:
-
-  LoadedObjectMap::iterator it, end = LoadedObjects.end();
-  for (it = LoadedObjects.begin(); it != end; ++it) {
-    ObjectImage *Obj = it->second;
-    if (Obj) {
-      NotifyFreeingObject(*Obj);
-      delete Obj;
-    }
-  }

Hey Andy, I've reverted this hunk in r193323 because without it we were seeing leaks from all the users of the MCJIT interface.

But I'm not 100% sure what you wanted the memory management strategy to be, so I wanted to follow up here in case there is a deeper problem or other solution we should be pursuing here.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131024/1ae5b3c5/attachment.html>