[PATCH] DebugInfo: Introduce the notion of "form classes"
Alexey Samsonov
samsonov at google.com
Thu Oct 24 06:10:35 PDT 2013
================
Comment at: include/llvm/DebugInfo/DWARFFormValue.h:65
@@ -47,6 +64,3 @@
- uint64_t getReference(const DWARFUnit *U) const;
- uint64_t getUnsigned() const { return Value.uval; }
- int64_t getSigned() const { return Value.sval; }
- const char *getAsCString(const DWARFUnit *U) const;
- uint64_t getAsAddress(const DWARFUnit *U) const;
+ bool getAsReference(const DWARFUnit *U, uint64_t &Result) const;
+ bool getAsUnsignedConstant(uint64_t &Result) const;
----------------
Eric Christopher wrote:
> Should be able to use Optional here?
Good idea. Done.
http://llvm-reviews.chandlerc.com/D1961
More information about the llvm-commits
mailing list