[PATCH] chkstk for Windows
Yaron Keren
yaron.keren at gmail.com
Wed Oct 23 16:34:52 PDT 2013
Hi,
Rafael reverted the patch. I have now fixed both tests:
1) Added back the !Subtarget->isTargetEnvMacho() condition, this fixed
CodeGen\X86\win64_alloca_dynalloca.ll.
2) modified the second patch from isTargetWindows() to isOSWindows(). These
two are not the same - how confusing!!, this fixed
CodeGen\X86\mingw-alloca.ll.
I'll commit soon.
Yaron
2013/10/24 Anton Korobeynikov <anton at korobeynikov.info>
> > It's easy to bring back the !Subtarget->isTargetEnvMacho() condition
> but
> > is it correct?
> For now - yes. Looks like macho environment was used to build some EFI
> code...
>
> > mingw32 is COFF by default (unless -elf) so results should have been the
> > same as before, right?
> Yes.
>
> > Do the standard regression tests run at all under Windows? I'll try
> building
> > them right now.
> >
> > I'm fairly new at this, sorry for any trouble!
> No problem. You may want to revert your change for a moment, fix the
> problem and then recommit.
>
> --
> With best regards, Anton Korobeynikov
> Faculty of Mathematics and Mechanics, Saint Petersburg State University
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131024/fb1769b5/attachment.html>
More information about the llvm-commits
mailing list