[llvm] r193261 - Fix PR17631

Michael Liao michael.liao at intel.com
Wed Oct 23 11:32:43 PDT 2013


Author: hliao
Date: Wed Oct 23 13:32:43 2013
New Revision: 193261

URL: http://llvm.org/viewvc/llvm-project?rev=193261&view=rev
Log:
Fix PR17631

- Skip instructions added in prolog. For specific targets, prolog may
  insert helper function calls (e.g. _chkstk will be called when
  there're more than 4K bytes allocated on stack). However, these
  helpers don't use/def YMM/XMM registers.


Added:
    llvm/trunk/test/CodeGen/X86/pr17631.ll
Modified:
    llvm/trunk/lib/Target/X86/X86VZeroUpper.cpp

Modified: llvm/trunk/lib/Target/X86/X86VZeroUpper.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86VZeroUpper.cpp?rev=193261&r1=193260&r2=193261&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86VZeroUpper.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86VZeroUpper.cpp Wed Oct 23 13:32:43 2013
@@ -231,8 +231,17 @@ bool VZeroUpperInserter::processBasicBlo
   bool BBHasCall = false;
 
   for (MachineBasicBlock::iterator I = BB.begin(); I != BB.end(); ++I) {
-    MachineInstr *MI = I;
     DebugLoc dl = I->getDebugLoc();
+    MachineInstr *MI = I;
+
+    // Don't need to check instructions added in prolog.
+    // In prolog, special function calls may be added for specific targets
+    // (e.g. on Windows, a prolog helper '_chkstk' is called when the local
+    // variables exceed 4K bytes on stack.) These helpers won't use/def YMM/XMM
+    // registers.
+    if (MI->getFlag(MachineInstr::FrameSetup))
+      continue;
+
     bool isControlFlow = MI->isCall() || MI->isReturn();
 
     // Shortcut: don't need to check regular instructions in dirty state.

Added: llvm/trunk/test/CodeGen/X86/pr17631.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/pr17631.ll?rev=193261&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/X86/pr17631.ll (added)
+++ llvm/trunk/test/CodeGen/X86/pr17631.ll Wed Oct 23 13:32:43 2013
@@ -0,0 +1,22 @@
+; RUN: llc < %s -mcpu=core-avx-i -mtriple=i386-pc-win32 | FileCheck %s
+ 
+%struct_type = type { [64 x <8 x float>], <8 x float> }
+ 
+; Function Attrs: nounwind readnone
+declare i32 @llvm.x86.avx.movmsk.ps.256(<8 x float>)
+ 
+; Function Attrs: nounwind
+define i32 @equal(<8 x i32> %A) {
+allocas:
+  %first_alloc  = alloca [64 x <8 x i32>]
+  %second_alloc = alloca %struct_type
+ 
+  %A1 = bitcast <8 x i32> %A to <8 x float>
+  %A2 = call i32 @llvm.x86.avx.movmsk.ps.256(<8 x float> %A1)
+  ret i32 %A2
+}
+
+; CHECK: equal
+; CHECK-NOT: vzeroupper
+; CHECK: _chkstk
+; CHECK: ret





More information about the llvm-commits mailing list