[PATCH] Add llvm-c-test tool for testing llvm-c

Hans Wennborg hans at chromium.org
Mon Oct 21 13:45:51 PDT 2013


  The patch looks good to me.

  > whitequark commented on this revision.
  > I wonder if this is needed at all: the OCaml bindings have good coverage and essentially map to the C API as well.

  AFAIK, those aren't built, even less tested, by default?

  I think the nice thing with Anders's patch is that this will exercise llvm-c as part of a default build & test. It also serves as an example of how to use the API.


================
Comment at: tools/llvm-c-test/helpers.c:21
@@ +20,3 @@
+void tokenize_stdin(void (*cb)(char **tokens, int ntokens)) {
+  char line[1024];
+  char *tokbuf[MAX_TOKENS];
----------------
might as well use a macro for the size of line too


http://llvm-reviews.chandlerc.com/D1776



More information about the llvm-commits mailing list