[PATCH] Runtime support for the indirect function call checker.

Richard Smith richard at metafoo.co.uk
Sat Oct 19 20:04:32 PDT 2013


  LGTM with one minor change.


================
Comment at: lib/ubsan/lit_tests/lit.cfg:53-54
@@ -52,2 +52,4 @@
 # Define %clang substitution to use in test RUN lines.
-config.substitutions.append( ("%clang ", (" " + config.clang + " ")) )
+config.substitutions.append( ("%clang ", (" " + config.clang +
+                                          " --driver-mode=g++ ")) )
+
----------------
Oh, sorry, I'd completely misunderstood why you were using `--driver-mode=g++`. I think it would be better to have a `%clang` and a `%clangxx` here (with the `--driver-mode=g++` in the latter), as we do in Clang's lit tests.


http://llvm-reviews.chandlerc.com/D1339



More information about the llvm-commits mailing list