[PATCH] Fix PR17168 (DAG scheduler inserts DBG_VALUE before PHI with fast-isel)
Bill Wendling
isanbard at gmail.com
Thu Oct 17 21:48:48 PDT 2013
On Oct 17, 2013, at 9:34 PM, Bill Schmidt <wschmidt at linux.vnet.ibm.com> wrote:
> On Thu, 2013-10-17 at 21:08 -0700, Bill Wendling wrote:
>> LGTM, but man, that test case is horrible!
>>
>
> It really is, no question. It's a bugpoint-reduced test from the bug
> report, and the metadata is a huge enough mess that not much could be
> done about it automatically. I started trying to reduce the amount of
> metadata by hand, but quickly realized my folly. :/
>
Yeah. That's never easy to do. And bug point doesn't really do metadata well (read: at all).
> Thanks for the review!
>
NP!
-bw
More information about the llvm-commits
mailing list