[PATCH] Add a "no-split-stack" function attribute.

Luqman Aden me+llvm at luqman.ca
Thu Oct 17 13:16:59 PDT 2013


On Wed, Oct 16, 2013 at 11:54 AM, Rafael EspĂ­ndola
<rafael.espindola at gmail.com> wrote:
>>> Luqman, would you be ok with adding a split_stack attribute instead?
>>
>> To clarify, that is remove the EnableSegmentedStacks option and
>> instead have a per-fn split_stack attribute?
>
> Correct. The advantage is that then LTO of a file using split stacks
> (say rust) and one without (C++) will just work.
>
> Cheers,
> Rafael

Ok, I was taking a look at getting rid of EnableSegmentedStacks and just using
a per-function split-stack attribute and I've run into a few places
where that doesn't
really work since we're not in the context of a function, like
X86TargetLowering::resetOperationActions
where it decides what to set the operation action for ISD:DYNAMIC_STACKALLOC.




More information about the llvm-commits mailing list