[PATCH] Developer policy amendment re. non-disclosure
Alp Toker
alp at nuanti.com
Thu Oct 17 11:02:59 PDT 2013
I've incorporated Daniel's suggested changes with line spacing and a
typo fixed, plus the internal link in the original patch restored.
Am not particularly keen on the "to the patches themselves"
qualification but I understand Nadav feels strongly about this so have
kept it in the final patch as a compromise.
Will appreciate one further review of the final patch from a third party
and explicit OK-to-commit before landing this.
Alp.
On 17/10/2013 18:31, Nadav Rotem wrote:
> LGTM. Thank you :)
>
> On Oct 17, 2013, at 10:30 AM, Daniel Berlin <dberlin at dberlin.org> wrote:
>
>> Here is an updated patch, which also takes into account an issue Nadav
>> kindly pointed out offline.
>>
>> On Thu, Oct 17, 2013 at 10:11 AM, Daniel Berlin <dberlin at dberlin.org> wrote:
>>> How about this wording for patches:
>>>
>>> When submitting patches, please do not add confidentiality or
>>> non-disclosure notices. These notices conflict
>>> with the LLVM license, and may result in your contribution being excluded.
>>>
>>>
>>> and this for mailing lists:
>>>
>>> Please be aware that all public LLVM mailing lists are public and
>>> archived, and that notices of confidentially or non-disclosure cannot
>>> be respected.
>>>
>>>
>>>
>>> On Thu, Oct 17, 2013 at 10:06 AM, Nadav Rotem <nrotem at apple.com> wrote:
>>>> Alp,
>>>>
>>>> I am against it. Your email does not match the clause that you want to add to the LLVM docs. In your email you mentioned patches (which is fine), but in your patch you mentioned email clients, etc.
>>>>
>>>> Thanks,
>>>> Nadav
>>>>
>>>>
>>>>
>>>>
>>>> On Oct 17, 2013, at 9:57 AM, Alp Toker <alp at nuanti.com> wrote:
>>>>
>>>>> This patch amends the developer policy to discourage corporate
>>>>> non-disclosure or confidentiality signatures on patches intended for
>>>>> review, which would be at odds with the LLVM license.
>>>>>
>>>>> OK to commit?
>>>>>
>>>>> --
>>>>> http://www.nuanti.com
>>>>> the browser experts
>>>>>
>>>>> <llvm-signature-policy.patch>_______________________________________________
>>>>> llvm-commits mailing list
>>>>> llvm-commits at cs.uiuc.edu
>>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>> _______________________________________________
>>>> llvm-commits mailing list
>>>> llvm-commits at cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> <llvm-signature-policy.patch>
--
http://www.nuanti.com
the browser experts
-------------- next part --------------
commit ef018f4b297a8b1dea4ff6fa708875cf25d70bd7
Author: Alp Toker <alp at nuanti.com>
Date: Thu Oct 17 18:47:37 2013 +0100
Developer policy amendment regarding confidentiality notices
Thanks to Daniel Berlin and Nadav Rotem for amendments and feedback!
Discussion:
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20131014/191677.html
diff --git a/docs/DeveloperPolicy.rst b/docs/DeveloperPolicy.rst
index 0f2136a..71c0c98 100644
--- a/docs/DeveloperPolicy.rst
+++ b/docs/DeveloperPolicy.rst
@@ -68,6 +68,9 @@ of bugs and enhancements occurring in LLVM. We really appreciate people who are
proactive at catching incoming bugs in their components and dealing with them
promptly.
+Please be aware that all public LLVM mailing lists are public and archived, and
+that notices of confidentiality or non-disclosure cannot be respected.
+
.. _patch:
.. _one-off patches:
@@ -107,6 +110,10 @@ rather than ``Content-Disposition: attachment``. Apple Mail gamely displays such
a file inline, making it difficult to work with for reviewers using that
program.
+When submitting patches, please do not add confidentiality or non-disclosure
+notices to the patches themselves. These notices conflict with the `LLVM
+license`_ and may result in your contribution being excluded.
+
.. _code review:
Code Reviews
More information about the llvm-commits
mailing list