[llvm] r192775 - Revert r192758 (and r192759), "MC: Better handling of tricky symbol and section names"

[Hans Wennborg]

On Wed, Oct 16, 2013 at 9:32 AM, Reid Kleckner <rnk at google.com> wrote:
> On Wed, Oct 16, 2013 at 1:22 AM, NAKAMURA Takumi <geek4civic at gmail.com>
> wrote:
>>
>> Author: chapuni
>> Date: Wed Oct 16 03:22:49 2013
>> New Revision: 192775
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=192775&view=rev
>> Log:
>> Revert r192758 (and r192759), "MC: Better handling of tricky symbol and
>> section names"
>>
>> GNU AS didn't like quotes in symbol names.
>>
>>     Error: junk at end of line, first unrecognized character is `"'
>>
>>         .def "@feat.00";
>>         "@feat.00" = 1
>>
>> Reproduced on Cygwin's 2.23.52.20130309 and mingw32's 2.20.1.20100303.
>
>
> Hah.  I bet gas wasn't actually interpreting @feat.00 correctly in the first
> place.

nm'ing the files produced with gas (quotes removed) and clang -cc1as,
this is what it looks like:

a.cc:
int f() {
  return 5;
}

with gas:
00000000 b .bss
00000000 d .data
00000000 t .text
00000000 T __Z1fv

with clang:
00000000 t .text
00000001 a @feat.00
00000000 T __Z1fv

So if gas doesn't understand the @feat.00 thing, maybe we should only
do it when targeting win32 (which means using our own assembler,
right?), thereby avoiding this whole problem?

 - Hans