[PATCH] MCInstrAnalysis::evaluateBranch() silently fails without asserts

Jim Grosbach grosbach at apple.com
Wed Oct 16 12:00:43 PDT 2013


Hi Stephen,

Can you elaborate a bit on the problem you’re encountering? I’m having a hard time following whether this change is correct without an example to work through.

Thanks,

 Jim

On Oct 16, 2013, at 2:07 AM, Stephen Checkoway <s at pahtak.org> wrote:

> MCInstrAnalysis::evaluateBranch() was assuming that if the OperandType is MCOI::OPERAND_PCREL, then the operand was an immediate. This appears not to be the case.
> 
> I'm unsure if this is handling it correctly or if we should just give up immediately if it's not an immediate or something else.
> 
> I don't know how to write a test case for this since the assert only triggers in Debug.
> 
> -- 
> Stephen Checkoway
> 
> <MCInstrAnalysis-handle-expr.diff>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





More information about the llvm-commits mailing list