[llvm] r192758 - MC: Better handling of tricky symbol and section names

[Rafael Espíndola]

Replying on this thread too to make sure people see it:

It is strange. On linux, this works

.global "@feat.00";
.set "@feat.00", 1

but this fails

.global "@feat.00";
"@feat.00" = 1

Maybe we just need to change the asm streamer to use .set.

On 16 October 2013 12:37, Hans Wennborg <hans at chromium.org> wrote:
> Thank you for reverting, Takumi. I'll try to find the right solution.
>
>  - Hans
>
> On Wed, Oct 16, 2013 at 1:29 AM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
>> Hans, excuse me, I have reverted it in r192775.
>>
>> ...Takumi
>>
>> 2013/10/16 Hans Wennborg <hans at hanshq.net>:
>>> Author: hans
>>> Date: Tue Oct 15 20:20:40 2013
>>> New Revision: 192758
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=192758&view=rev
>>> Log:
>>> MC: Better handling of tricky symbol and section names
>>>
>>> Because of win32 mangling, we produce symbol and section names with
>>> funny characters in them, most notably @ characters.
>>>
>>> MC would choke on trying to parse its own assembly output. This patch addresses
>>> that by:
>>>
>>> - Making @ trigger quoting of symbol names
>>> - Also quote section names in the same way
>>> - Just parse section names like other identifiers (to allow for quotes)
>>> - Don't assume @ signifies a symbol variant if it is in a string.
>>>
>>> Differential Revision: http://llvm-reviews.chandlerc.com/D1945
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits