[PATCH] [asan] Optimize accesses to global arrays with constant index

Alexey Samsonov samsonov at google.com
Wed Oct 16 07:04:05 PDT 2013


  LGTM with minor nits


================
Comment at: test/Instrumentation/AddressSanitizer/instrument_global.ll:34
@@ +33,3 @@
+    ret i32 %0
+; CHECK: define i32 @AccessGlobSt_0_12
+; CHECK: __asan_report
----------------
I think you may use CHECK-LABEL: directive to match function names

================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:706
@@ -683,1 +705,3 @@
 
+  if (IsWrite) NumInstrumentedWrites++;
+  else         NumInstrumentedReads++;
----------------
clang-format this?


http://llvm-reviews.chandlerc.com/D1947

BRANCH
  svn

ARCANIST PROJECT
  llvm



More information about the llvm-commits mailing list