[PATCH] Fix MCDataAtom never calling remap when adding data.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed Oct 16 06:51:21 PDT 2013


On 16 October 2013 09:16, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
> Can this be tested via llvm-mc?

I now see that it is used from the disassembler. Every current users
creates the Atom with as much space as it will ever need.

The case of

 InvalidData = Module->createDataAtom(CurAddr, EndAddr);

looks like a bug. The atom is made to go all the way to the end of
section, but we keep trying to disassemble. If we succeed we will have
overlapping atoms.

In other words, there are not that many users, so the patch with the
unit test LGTM.

Cheers,
Rafael




More information about the llvm-commits mailing list