[PATCH] Add NATIVE_EXEC macro for building client for running in DynamoRIO hybrid mode only

Evgeniy Stepanov eugenis at google.com
Wed Oct 16 02:35:52 PDT 2013



================
Comment at: CMakeLists.txt:7
@@ -6,1 +6,3 @@
 
+  option(NATIVE_EXEC "Building client for running in DynamoRIO hybrid mode, which allows some module running natively" ON)
+  if (NATIVE_EXEC)
----------------
Please call it MSANDR_NATIVE_EXEC

================
Comment at: msandr.cc:395
@@ -382,3 +394,3 @@
 
-  if (ShouldInstrumentPc(pc, NULL))
+  if (IF_NE_ELSE(true, ShouldInstrumentPc(pc, NULL)))
     CHECK(drutil_expand_rep_string(drcontext, bb));
----------------
I'd prefer to just use #ifdef NATIVE_EXEC here, it would be about the same amount of code.
Also, IF_NE is common abbreviation for "if not equal", which is misleading.



http://llvm-reviews.chandlerc.com/D1942



More information about the llvm-commits mailing list