LGTM ================ Comment at: lib/MC/MCParser/AsmParser.cpp:798 @@ +797,3 @@ + + if (FirstTokenKind != AsmToken::String && Identifier.count('@')) { + std::pair<StringRef, StringRef> Split = Identifier.split('@'); ---------------- No need to scan twice, the split is cheap. http://llvm-reviews.chandlerc.com/D1945