[PATCH] COFF MC: better handling of tricky symbol and section names

David Majnemer david.majnemer at gmail.com
Tue Oct 15 16:59:37 PDT 2013



================
Comment at: lib/MC/MCSectionCOFF.cpp:45
@@ +44,3 @@
+      (C < 'A' || C > 'Z') &&
+      (C < '0' || C > '9') &&
+      C != '_' && C != '$' && C != '.')
----------------
David Majnemer wrote:
> Aren't these three lines equivalent to `std::isalnum(C, std::locale("C"))`?
Actually, `std::locale::classic()` is probably a bit better than `std::locale("C")` as it avoids parsing the constructor argument.


http://llvm-reviews.chandlerc.com/D1945



More information about the llvm-commits mailing list