[llvm] r192731 - Remove some dead code. (DarwinGDBCompat was retired in r189903).

Eric Christopher echristo at gmail.com
Tue Oct 15 14:08:48 PDT 2013


Hey, thanks :)

-eric

On Tue, Oct 15, 2013 at 1:26 PM, Adrian Prantl <aprantl at apple.com> wrote:
> Author: adrian
> Date: Tue Oct 15 15:26:37 2013
> New Revision: 192731
>
> URL: http://llvm.org/viewvc/llvm-project?rev=192731&view=rev
> Log:
> Remove some dead code. (DarwinGDBCompat was retired in r189903).
>
> Modified:
>     llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
>     llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.h
>
> Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=192731&r1=192730&r2=192731&view=diff
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)
> +++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Tue Oct 15 15:26:37 2013
> @@ -196,9 +196,8 @@ DwarfDebug::DwarfDebug(AsmPrinter *A, Mo
>    DwarfAbbrevDWOSectionSym = DwarfStrDWOSectionSym = 0;
>    FunctionBeginSym = FunctionEndSym = 0;
>
> -  // Turn on accelerator tables and older gdb compatibility
> -  // for Darwin by default, pubnames by default for non-Darwin,
> -  // and handle split dwarf.
> +  // Turn on accelerator tables for Darwin by default, pubnames by
> +  // default for non-Darwin, and handle split dwarf.
>    bool IsDarwin = Triple(A->getTargetTriple()).isOSDarwin();
>
>    if (DwarfAccelTables == Default)
> @@ -223,8 +222,6 @@ DwarfDebug::DwarfDebug(AsmPrinter *A, Mo
>      beginModule();
>    }
>  }
> -DwarfDebug::~DwarfDebug() {
> -}
>
>  // Switch to the specified MCSection and emit an assembler
>  // temporary label to it if SymbolStem is specified.
>
> Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.h?rev=192731&r1=192730&r2=192731&view=diff
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.h (original)
> +++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.h Tue Oct 15 15:26:37 2013
> @@ -429,9 +429,6 @@ class DwarfDebug {
>    // Holders for the various debug information flags that we might need to
>    // have exposed. See accessor functions below for description.
>
> -  // Whether or not we're emitting info for older versions of gdb on darwin.
> -  bool IsDarwinGDBCompat;
> -
>    // Holder for imported entities.
>    typedef SmallVector<std::pair<const MDNode *, const MDNode *>, 32>
>      ImportedEntityMap;
> @@ -661,7 +658,6 @@ public:
>    // Main entry points.
>    //
>    DwarfDebug(AsmPrinter *A, Module *M);
> -  ~DwarfDebug();
>
>    /// \brief Emit all Dwarf sections that should come prior to the
>    /// content.
> @@ -702,10 +698,6 @@ public:
>    /// \brief Recursively Emits a debug information entry.
>    void emitDIE(DIE *Die, std::vector<DIEAbbrev *> *Abbrevs);
>
> -  /// \brief Returns whether or not to limit some of our debug
> -  /// output to the limitations of darwin gdb.
> -  bool useDarwinGDBCompat() { return IsDarwinGDBCompat; }
> -
>    // Experimental DWARF5 features.
>
>    /// \brief Returns whether or not to emit tables that dwarf consumers can
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list