[llvm] r192690 - Add AllTargetsBindings sublibrary instead of having static inlines in the llvm-c headers.

Anders Waldenborg anders at 0x63.nu
Tue Oct 15 13:30:40 PDT 2013


On Tue, Oct 15, 2013 at 09:12:14PM +0800, 罗勇刚(Yonggang Luo)  wrote:
> > Also darwin+cmake it seems. I'll revert it until I understand why it
> > fails (or rather why it doesn't fail on linux - the libLTO uses
> > explicit list of targets instead of the all-targets component, so it
> > doesn't get the AllTargetsBindings sublibrary).
> >
>
> I can explain, that's just because the dllexport of msvc

But that isn't really the whole story. It shouldn't really have
managed to build on linux+cmake either, as it uses
${LLVM_TARGETS_TO_BUILD} where autoconf based build uses all-targets,
and thus does not get the AllTargetsBindings library at all.

I thinking it might be possible to handle it as in attached patch.
Which adds "all-targets" as a valid component in cmake too, which then
also can include the AllTargetsBindings. This would make it behave
same way as components in autoconf builds. Not sure this is a good idea.

 anders
-------------- next part --------------
A non-text attachment was scrubbed...
Name: alltargets.patch
Type: text/x-diff
Size: 4358 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131015/71f7ad82/attachment.patch>


More information about the llvm-commits mailing list