[PATCH] Emit Clang version information into .comment section (MC's part of implementation) [PART 2B]

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Oct 15 11:02:09 PDT 2013


Just one more thing: can you please rebase the patch. It doesn't apply
cleanly on trunk.

On 15 October 2013 13:48, Katya Romanova
<Katya_Romanova at playstation.sony.com> wrote:
>   Good catch. I guess I shouldn't do sanity checking a week after I did my changes :(. I had it set to "false" all along, but changed it to the opposite last minute because I thought it was X86Asm.
>
>   I attached a new patch  with the correction.
>   Thanks for the review.
>
> Hi rafael,
>
> http://llvm-reviews.chandlerc.com/D1812
>
> CHANGE SINCE LAST DIFF
>   http://llvm-reviews.chandlerc.com/D1812?vs=4903&id=4923#toc
>
> Files:
>   include/llvm/MC/MCELFStreamer.h
>   include/llvm/MC/MCStreamer.h
>   include/llvm/MC/MCAsmInfo.h
>   lib/Target/X86/MCTargetDesc/X86MCAsmInfo.cpp
>   lib/MC/MCAsmStreamer.cpp
>   lib/MC/MCAsmInfo.cpp
>   lib/MC/MCELFStreamer.cpp
>   lib/MC/WinCOFFStreamer.cpp
>   lib/MC/MCPureStreamer.cpp
>   lib/MC/MCMachOStreamer.cpp
>   lib/MC/MCParser/ELFAsmParser.cpp



More information about the llvm-commits mailing list