[llvm] r190536 - Revert "Give internal classes hidden visibility."

[Benjamin Kramer]

> On 15.10.2013, at 02:54, "Rafael Espíndola" <rafael.espindola at gmail.com> wrote:
>
>> On 11 September 2013 14:05, Benjamin Kramer <benny.kra at googlemail.com> wrote:
>> Author: d0k
>> Date: Wed Sep 11 13:05:11 2013
>> New Revision: 190536
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=190536&view=rev
>> Log:
>> Revert "Give internal classes hidden visibility."
>>
>> It works with clang, but GCC has different rules so we can't make all of those
>> hidden. This reverts commit r190534.
>
> Do you have a reduced testcase of what the difference was?

No, but the problem was that classes were becoming hidden if one of
its members had hidden visibility.

class LIBRARY_VISIBILITY LLVMContextImpl {};

class LLVMContext { LLVMContextImpl *Impl; };

Now the latter class became hidden. This seemed to be not the case
with my build of Clang at the time.

- Ben