[PATCH] Remove leftover profiling pieces

Rafael EspĂ­ndola rafael.espindola at gmail.com
Mon Oct 14 09:57:14 PDT 2013


Committed as r192605, r192606 and r192607.

Thanks !

On 14 October 2013 12:28, Alastair Murray <alastairmurray42 at gmail.com> wrote:
> All,
>
> I should have said in the original email: I do not have commit access,
> someone else will have to commit the changes (thanks in advance!).
>
>
> On 14/10/13 09:51, Rafael EspĂ­ndola wrote:
>>
>> LGTM, Thanks!
>>
>> On 10 October 2013 15:45, Alastair Murray <alastairmurray42 at gmail.com>
>> wrote:
>>>
>>> Hi all,
>>>
>>> Further to Chandler Carruth's commit r191835 to remove the old profiling
>>> framework, here are few more patches to remove a few things that I think
>>> he
>>> missed.  Chandler, I've CC'ed you in case these were left deliberately.
>>>
>>> (As an aside, as someone who has dealt with LLVM profiling before and who
>>> was responsible for the most recent abandoned attempt to reboot it, I'm
>>> very
>>> happy to see a clean slate and I hope to be able to provide patches
>>> building
>>> on the newly proposed models.)
>>>
>>> Patches:
>>> 1-remove-profiling-utils.patch
>>> 'svn remove lib/Transforms/Instrumentation/ProfilingUtils.*', and a few
>>> updates that this required.
>>>
>>> 2-svn-remove-utils-profile-pl.patch
>>> 'svn remove utils/profile.pl'.  I'm pretty sure this hasn't worked in
>>> years,
>>> it definitely doesn't work now (it uses the removed opt arguments).
>>>
>>> 3-svn-remove-testsuite-profile-makefile.patch
>>> In the test-suite, 'svn remove TEST.profile.*', I'd be happy to revive
>>> these
>>> in the future, but for now they use the removed opt arguments.
>>>
>>> Tested by recompiling and 'make check-all', and 'make TEST=simple report'
>>> on
>>> the test-suite.
>>>
>>> Regards,
>>> Alastair.
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>> .
>>
>




More information about the llvm-commits mailing list