[PATCH] AArch64 Neon Scalar Integer Compare Instructions

mcrosier at codeaurora.org mcrosier at codeaurora.org
Mon Oct 14 06:45:12 PDT 2013


I believe it's in pretty good shape.  Thanks for the LTGM, James.  I'll
push it in a bit.

 Chad

> Hi Chad,
>
> I haven't done a massively in-depth review - I compared with Tim's
> previous
> comments and it looks like everything he mentioned is fixed, so LGTM.
>
> Cheers,
>
> James
>
>
> On 11 October 2013 14:54, <mcrosier at codeaurora.org> wrote:
>
>> > Hi Chad,
>> >
>> >> Please have a look and give the LGTM if you're satisfied.
>> >
>> > It looks like you've attached the arithmetic LLVM patch rather than
>> > the compare one. I'm afraid someone else will have to take over the
>> > review next week.
>>
>> Epic fail! :(
>>
>> Revised patches attached.  If someone else could take a look (Joey, Jim,
>> James), I would greatly appreciate a review!
>>
>>  Chad
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>>
>





More information about the llvm-commits mailing list