[PATCH] MC: Use StringRef to avoid strcmp/strlen on non-null-term'd strings.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Sun Oct 13 10:46:28 PDT 2013


>> Are either concerns something to be sufficiently concerned about that
>> they should be measured, and if so any recommenedations on how I might
>> do so?
>
> I would prefer not doing this.
>
> * StringRef in a compile-time initialized array adds static initializers because the struct is no longer POD.

I don't think this code is used in static initializers. I got the same
size for .init and .init_array when building clang with and without
this patch in debug mode.

Cheers,
Rafael



More information about the llvm-commits mailing list