[llvm] r192504 - Adding multiple object support to MCJIT EH frame handling

[Kaylor, Andrew]

Yeah, that method definitely should return 0.

Making it do so introduces a test failure.  I'll commit a correction as soon as I figure out what's going on.

-Andy

-----Original Message-----
From: Benjamin Kramer [mailto:benny.kra at gmail.com] 
Sent: Friday, October 11, 2013 3:08 PM
To: Kaylor, Andrew
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm] r192504 - Adding multiple object support to MCJIT EH frame handling

On Fri, Oct 11, 2013 at 11:25 PM, Andrew Kaylor <andrew.kaylor at intel.com> wrote: 
<snip>
> --- llvm/trunk/tools/lli/RemoteMemoryManager.h (original)
> +++ llvm/trunk/tools/lli/RemoteMemoryManager.h Fri Oct 11 16:25:48 
> +++ 2013
> @@ -74,13 +74,20 @@ public:
>                                 unsigned SectionID, StringRef SectionName,
>                                 bool IsReadOnly);
>
> -  void *getPointerToNamedFunction(const std::string &Name,
> -                                  bool AbortOnFailure = true);
> +  // For now, remote symbol resolution is not support in lli.  The 
> + MCJIT  // interface does support this, but clients must provide 
> + their own  // mechanism for finding remote symbol addresses.  MCJIT 
> + will resolve  // symbols from Modules it contains.
> +  uint64_t getSymbolAddress(const std::string &Name) {}

This method should return something.

- Ben