LGTM. Closer reading of the ABI addendum shows that these are PCS attributes and describe compatibility with the ABI rather than the available target features - apologies for missing it in the last review. http://llvm-reviews.chandlerc.com/D1900