[PATCH][ARM] Add no-fpu test case

Amara Emerson amara.emerson at arm.com
Fri Oct 11 01:31:19 PDT 2013


Hi Renato,

Thanks for taking a look.

> The test is a bit confusing, as it has too many identical checks for
different (but very similar) tags. Also, NONEON and NONEON-VFP is identical
for the purposes of this test.

While in effect the features for cortex-a8 may be the same for -neon and
-neon,+vfp2/3, this test is just to ensure that disabling NEON doesn't
disable VFP for whatever reason in future. The test should be CPU agnostic
whatever the default is.

> By default, armv7 selects Coertex-A8, which has VFP3, so you may want:

I'm using the vfp2 string because it should disable the entire VFP unit, not
just the VFPv3 extensions.

> * NEON: (-mattr=-vfp3),

This will have the opposite effect since disabling VFP will also disable
NEON.

Thanks,
Amara







More information about the llvm-commits mailing list