[lld] r192423 - Remove excessive allowRemainingUndefines() check.

Rui Ueyama ruiu at google.com
Thu Oct 10 23:16:35 PDT 2013


Author: ruiu
Date: Fri Oct 11 01:16:35 2013
New Revision: 192423

URL: http://llvm.org/viewvc/llvm-project?rev=192423&view=rev
Log:
Remove excessive allowRemainingUndefines() check.

allowRemainingUndefines() is already checked in Resolver::resolve(), so we
don't need to check it again after returning from it. It's actually not only
superfluous but buggy because a failure of resolve() does not always mean that
there is a remaining undefines.

Modified:
    lld/trunk/lib/Driver/Driver.cpp

Modified: lld/trunk/lib/Driver/Driver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Driver/Driver.cpp?rev=192423&r1=192422&r2=192423&view=diff
==============================================================================
--- lld/trunk/lib/Driver/Driver.cpp (original)
+++ lld/trunk/lib/Driver/Driver.cpp Fri Oct 11 01:16:35 2013
@@ -107,10 +107,8 @@ bool Driver::link(LinkingContext &contex
   // Do core linking.
   ScopedTask resolveTask(getDefaultDomain(), "Resolve");
   Resolver resolver(context);
-  if (!resolver.resolve()) {
-    if (!context.allowRemainingUndefines())
-      return false;
-  }
+  if (!resolver.resolve())
+    return false;
   MutableFile &merged = resolver.resultFile();
   resolveTask.end();
 





More information about the llvm-commits mailing list